Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13669 )
Change subject: [docs] Add 1.10.0 release notes ...................................................................... Patch Set 1: (12 comments) http://gerrit.cloudera.org:8080/#/c/13669/1/docs/release_notes.adoc File docs/release_notes.adoc: http://gerrit.cloudera.org:8080/#/c/13669/1/docs/release_notes.adoc@70 PS1, Line 70: . nit: extra period http://gerrit.cloudera.org:8080/#/c/13669/1/docs/release_notes.adoc@97 PS1, Line 97: single client nit: "single-client"? "leverages a single client"? http://gerrit.cloudera.org:8080/#/c/13669/1/docs/release_notes.adoc@123 PS1, Line 123: tableExists() (Java) and TableExists() nit: surround code in backticks http://gerrit.cloudera.org:8080/#/c/13669/1/docs/release_notes.adoc@130 PS1, Line 130: speed up nit: speed-up http://gerrit.cloudera.org:8080/#/c/13669/1/docs/release_notes.adoc@169 PS1, Line 169: PartialRow and RowResult nit: surround code in backticks http://gerrit.cloudera.org:8080/#/c/13669/1/docs/release_notes.adoc@183 PS1, Line 183: /metrics Should this have backticks? http://gerrit.cloudera.org:8080/#/c/13669/1/docs/release_notes.adoc@186 PS1, Line 186: in the cluster. : nit: on a tablet server? http://gerrit.cloudera.org:8080/#/c/13669/1/docs/release_notes.adoc@201 PS1, Line 201: Now the value : of 0 means "no rows to generate", not "maximum rows to generate". Starting this : Kudu version, use -1 as a special value for the "maximum rows to generate" : semantics. How about: "A value of 0 now indicates that no rows should be generated, and a value of -1 indicates there should be no limit to the number of rows generated." http://gerrit.cloudera.org:8080/#/c/13669/1/docs/release_notes.adoc@206 PS1, Line 206: “make install” nit: surround code in backticks http://gerrit.cloudera.org:8080/#/c/13669/1/docs/release_notes.adoc@216 PS1, Line 216: KUDU-1868 link? And spacing. http://gerrit.cloudera.org:8080/#/c/13669/1/docs/release_notes.adoc@218 PS1, Line 218: SERVICE_UNAVAILABLE Should this have backticks? http://gerrit.cloudera.org:8080/#/c/13669/1/docs/release_notes.adoc@298 PS1, Line 298: Csaba Fulop : : Florentino Sainz : : Guangchao Deng : : Jia Hongchao : : Ye Yuqiang : : Yifan Zhang Should this be a bulleted list? -- To view, visit http://gerrit.cloudera.org:8080/13669 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.10.x Gerrit-MessageType: comment Gerrit-Change-Id: I040df9debdf78f1bd932915164a1b6ba490be135 Gerrit-Change-Number: 13669 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 19 Jun 2019 01:47:10 +0000 Gerrit-HasComments: Yes
