Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13681 )
Change subject: KUDU-2870: allow super-user to skip authz checks in Checksum ...................................................................... Patch Set 5: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/13681/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13681/5//COMMIT_MSG@15 PS5, Line 15: control as a super-user nit: maybe, rephrase a bit for clarity: ... control; the tool is run under super-user credentials. http://gerrit.cloudera.org:8080/#/c/13681/5/src/kudu/tserver/tablet_server_authorization-test.cc File src/kudu/tserver/tablet_server_authorization-test.cc: PS5: nit: maybe, remove the changes in this file since they are not essential and keep the original version (at least between base and PS5 I don't see any significant changes)? http://gerrit.cloudera.org:8080/#/c/13681/2/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/13681/2/src/kudu/tserver/tablet_service.cc@887 PS2, Line 887: } : : bool TabletServiceImpl::AuthorizeClient(const google::protobuf::Message* /*req*/, : google::protobuf::Message* /*resp*/, : rpc::RpcContext* context) { : return server_->Authorize(context, ServerBase::SUPER_USER | ServerBase::USER); : } : > I realized that we don't need the FLAGS_checksum_require_authz_token flag i Ah, good idea. That's even better, indeed -- that way we achieve what we want and aren't introducing some extra flag. SGTM -- To view, visit http://gerrit.cloudera.org:8080/13681 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9da21f41702da747a081ab037d75865748d981a8 Gerrit-Change-Number: 13681 Gerrit-PatchSet: 5 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 20 Jun 2019 02:47:26 +0000 Gerrit-HasComments: Yes
