Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13692 )
Change subject: [java] KUDU-2873: attach authz tokens to SplitKeyRangeRequests ...................................................................... Patch Set 2: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/13692/2/java/kudu-client/src/main/java/org/apache/kudu/client/SplitKeyRangeRequest.java File java/kudu-client/src/main/java/org/apache/kudu/client/SplitKeyRangeRequest.java: http://gerrit.cloudera.org:8080/#/c/13692/2/java/kudu-client/src/main/java/org/apache/kudu/client/SplitKeyRangeRequest.java@136 PS2, Line 136: } nit: anything changed here? http://gerrit.cloudera.org:8080/#/c/13692/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthTokenReacquire.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthTokenReacquire.java: http://gerrit.cloudera.org:8080/#/c/13692/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthTokenReacquire.java@195 PS2, Line 195: null, null, null, null nit: comment the variable names? -- To view, visit http://gerrit.cloudera.org:8080/13692 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2b4140076206f25b34d8025b45118e3ff7b4b826 Gerrit-Change-Number: 13692 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yao Xu <[email protected]> Gerrit-Comment-Date: Thu, 20 Jun 2019 22:47:54 +0000 Gerrit-HasComments: Yes
