Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13707 )

Change subject: thirdparty: fix build-if-necessary in tarballs
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13707/1/thirdparty/build-if-necessary.sh
File thirdparty/build-if-necessary.sh:

http://gerrit.cloudera.org:8080/#/c/13707/1/thirdparty/build-if-necessary.sh@89
PS1, Line 89:         grep -v '^\./\.build-stamp' |
            :         grep -v '^\.$' |
> This is functional, I suppose that could be done in a follow up. We use thi
SGTM



--
To view, visit http://gerrit.cloudera.org:8080/13707
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.10.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc600d065362e902f4f768080e1f91c90b9f0594
Gerrit-Change-Number: 13707
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Hao Hao <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Comment-Date: Fri, 21 Jun 2019 21:16:44 +0000
Gerrit-HasComments: Yes

Reply via email to