Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/13659 )
Change subject: [maintenance] Add extra config for maintenance manager task priority ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/13659/1/src/kudu/common/wire_protocol.cc File src/kudu/common/wire_protocol.cc: http://gerrit.cloudera.org:8080/#/c/13659/1/src/kudu/common/wire_protocol.cc@681 PS1, Line 681: int32_t history_max_age_sec; : RETURN_NOT_OK(ParseIntConfig(name, value, &history_max_age_sec)); : result.set_history_max_age_sec(history_max_age_sec); : } > Maybe we can optimize the duplicate code here. Done -- To view, visit http://gerrit.cloudera.org:8080/13659 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I966ee626ef85ce56ba4517b9e494f3ac5b044867 Gerrit-Change-Number: 13659 Gerrit-PatchSet: 2 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yao Xu <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Sun, 23 Jun 2019 06:11:51 +0000 Gerrit-HasComments: Yes
