Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13733 )
Change subject: KUDU-2851: modify table scan tool to surface errors instead of crashing ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/13733/3//COMMIT_MSG Commit Message: PS3: So it'll be clear when looking back through old commits, could you also mention the similar work you did for `table copy`? http://gerrit.cloudera.org:8080/#/c/13733/3/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/13733/3/src/kudu/tools/kudu-tool-test.cc@5028 PS3, Line 5028: ser nit: Can you remove the extra whitespace here? Same below, and above in patchset 4 http://gerrit.cloudera.org:8080/#/c/13733/3/src/kudu/tools/kudu-tool-test.cc@5035 PS3, Line 5035: enfo nit: this is the copy tool :) http://gerrit.cloudera.org:8080/#/c/13733/3/src/kudu/tools/table_scanner.cc File src/kudu/tools/table_scanner.cc: http://gerrit.cloudera.org:8080/#/c/13733/3/src/kudu/tools/table_scanner.cc@628 PS3, Line 628: : for (i = 0; i < FLAGS_num_threads; ++i) { : if (!thread_statuses[i].ok() && out_) { : *out_ << "Scanning failed " << thread_statuses[i].ToString() << endl; : if (end_status.ok()) end_status = thread_statuses[i]; : } : } Looking at TableScanner's out_ a bit, it's possible that `out_` never gets set via SetOutput(). In such cases, `out_` will be nullptr, and this will be skipped. Could you tweak this a bit so `end_status` gets set correctly, regardless of whether `out_` is set or not? Also, minor nit: could you move this Status-parsing and printing so it comes after `sw.stop()`? While generally pretty negligible, printing and branches do take time, and it'd be nice to entirely separate this from the scan being timed. -- To view, visit http://gerrit.cloudera.org:8080/13733 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic45da537b8bacfa9625010536ea82da9a6e76100 Gerrit-Change-Number: 13733 Gerrit-PatchSet: 4 Gerrit-Owner: Hannah Nguyen <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 26 Jun 2019 23:31:34 +0000 Gerrit-HasComments: Yes
