Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13742 )
Change subject: [loadgen] don't report per-row timing if errors happened ...................................................................... Patch Set 1: Code-Review+2 I was confused at first about the motivation for this because I thought total_row_count was the total successfully inserted. I clarified this with Alexey, it's actually the total generated and attempted to be inserted. Maybe with some variable renaming this could be clearer, though not a blocker for this patch; otherwise this change LGTM. -- To view, visit http://gerrit.cloudera.org:8080/13742 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I501aad05fa6bd8a5b540c53c8e3f27baff4bde84 Gerrit-Change-Number: 13742 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 26 Jun 2019 23:41:37 +0000 Gerrit-HasComments: No
