Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13733 )
Change subject: KUDU-2851: modify table scan and copy tools to surface errors ...................................................................... Patch Set 8: -Code-Review (1 comment) http://gerrit.cloudera.org:8080/#/c/13733/8/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/13733/8/src/kudu/tools/kudu-tool-test.cc@5037 PS8, Line 5037: // Set flags so scans are rejected because they're not authorized. : ASSERT_OK(cluster_->SetFlag(cluster_->tablet_server(0), : "tserver_enforce_access_control", "true")); : ASSERT_OK(cluster_->SetFlag(cluster_->tablet_server(0), : "tserver_inject_invalid_authz_token_ratio", "1.0")); Ah hrm, looks like the behavior of this isn't super reliable for failing the same way every time. Nor does it seem to make the test run any faster. Let's revert this to just shutting down the tablet server. Same below. -- To view, visit http://gerrit.cloudera.org:8080/13733 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic45da537b8bacfa9625010536ea82da9a6e76100 Gerrit-Change-Number: 13733 Gerrit-PatchSet: 8 Gerrit-Owner: Hannah Nguyen <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hannah Nguyen <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: helifu <[email protected]> Gerrit-Comment-Date: Thu, 27 Jun 2019 04:50:10 +0000 Gerrit-HasComments: Yes
