Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13784 )
Change subject: [tserver] Fix bug in AlterSchemaTransactionState::ToString ...................................................................... [tserver] Fix bug in AlterSchemaTransactionState::ToString The error_ condition is reversed, When error is null the tserver will crash. Stacktrace: 0x21f5dcc google::protobuf::TextFormat::Printer::Print() 0x21f5e6d google::protobuf::TextFormat::Printer::PrintToString() 0x204e335 kudu::pb_util::SecureShortDebugString() 0xbeae76 kudu::tablet::AlterSchemaTransactionState::ToString() 0xbead3f kudu::tablet::AlterSchemaTransaction::ToString() 0xbedaea kudu::tablet::TransactionDriver::ToString() 0xbf41e1 kudu::tablet::TransactionTracker::WaitForAllToFinish() 0xbf496f kudu::tablet::TransactionTracker::WaitForAllToFinish() 0xbe543f kudu::tablet::TabletReplica::Stop() 0x9cd198 kudu::tserver::TSTabletManager::DeleteTablet() 0x9d2f5f kudu::tserver::DeleteTabletRunnable::Run() 0x207365f kudu::ThreadPool::DispatchThread() 0x2068ec4 kudu::Thread::SuperviseThread() 0x7f01548b2dc5 start_thread 0x7f0152b8dced __clone Deleting old range partion, which will wait for all txns to finish. If being dumped txns contains 'AlterSchema-TXN', the tserver will crash. Change-Id: I7126edcdddae9cf21d343e6c6c219a003edb1be1 Reviewed-on: http://gerrit.cloudera.org:8080/13782 Tested-by: Kudu Jenkins Reviewed-by: Andrew Wong <[email protected]> Reviewed-by: Grant Henke <[email protected]> (cherry picked from commit 81f0dbf99ac2114a29431f49fa2ef480e7ef26c4) Reviewed-on: http://gerrit.cloudera.org:8080/13784 --- M src/kudu/tablet/transactions/alter_schema_transaction.cc M src/kudu/tablet/transactions/alter_schema_transaction.h 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Andrew Wong: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/13784 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.10.x Gerrit-MessageType: merged Gerrit-Change-Id: I7126edcdddae9cf21d343e6c6c219a003edb1be1 Gerrit-Change-Number: 13784 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: XiaokaiWang <[email protected]>
