Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13796 )
Change subject: KUDU-2722 (table level): Support new 'write_enabled' table extra config ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/13796/2/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/13796/2/src/kudu/tserver/tablet_service.cc@1083 PS2, Line 1083: bool TabletIsWritable(shared_ptr<Tablet> tablet) { > warning: the parameter 'tablet' is copied for each invocation but only used This is also a good suggestion that you should adopt. http://gerrit.cloudera.org:8080/#/c/13796/2/src/kudu/tserver/tablet_service.cc@1084 PS2, Line 1084: boost::optional<TableExtraConfigPB> extra_config = tablet->metadata()->extra_config(); > This makes a copy, so consider storing a cref: Looks like you missed this. -- To view, visit http://gerrit.cloudera.org:8080/13796 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibd3768eda36d9574be9c41e7cd3dd81cc5ae8f3a Gerrit-Change-Number: 13796 Gerrit-PatchSet: 4 Gerrit-Owner: XiaokaiWang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: XiaokaiWang <[email protected]> Gerrit-Reviewer: Yao Xu <[email protected]> Gerrit-Comment-Date: Wed, 10 Jul 2019 16:21:16 +0000 Gerrit-HasComments: Yes
