helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13821 )
Change subject: KUDU-2855 Lazy-create DeltaMemStore on first update ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/13821/3/src/kudu/tablet/delta_tracker.h File src/kudu/tablet/delta_tracker.h: http://gerrit.cloudera.org:8080/#/c/13821/3/src/kudu/tablet/delta_tracker.h@374 PS3, Line 374: // Number of deleted rows for a DMS that is currently being flushed. > Nit: what changed here? There is a ^M at the end. http://gerrit.cloudera.org:8080/#/c/13821/2/src/kudu/tablet/delta_tracker.h File src/kudu/tablet/delta_tracker.h: http://gerrit.cloudera.org:8080/#/c/13821/2/src/kudu/tablet/delta_tracker.h@336 PS2, Line 336: const scoped_refptr<log::LogAnchorRegistry> log_anchor_registry_; > I don't understand your explanation. When log_anchor_registry_ was a raw po Yes, when log_anchor_registry_ was a raw pointer, it pointed to the scoped_refptr owned by Tablet. But, in test cases, this raw pointer is not very safe to use: https://github.com/apache/kudu/blob/3cbc0d4fbe295748d6ffdf1e5e7edeaf94ef0911/src/kudu/tablet/diskrowset-test-base.h#L330 https://github.com/apache/kudu/blob/09e089bfafb9a1fa2099bd43cd0bd786dad0e771/src/kudu/tablet/diskrowset-test.cc#L759 http://gerrit.cloudera.org:8080/#/c/13821/2/src/kudu/tablet/delta_tracker.cc File src/kudu/tablet/delta_tracker.cc: http://gerrit.cloudera.org:8080/#/c/13821/2/src/kudu/tablet/delta_tracker.cc@78 PS2, Line 78: DEFINE_bool(dms_lazy_create, true, : "Allow lazily creating of DeltaMemStore"); : TAG_FLAG(dms_lazy_create, advanced > I'd discard it; it doesn't seem important enough to expose. ok. -- To view, visit http://gerrit.cloudera.org:8080/13821 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie0c565d86647d5144266b30aa6e8572d42db48c6 Gerrit-Change-Number: 13821 Gerrit-PatchSet: 3 Gerrit-Owner: helifu <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: helifu <[email protected]> Gerrit-Comment-Date: Wed, 10 Jul 2019 22:05:02 +0000 Gerrit-HasComments: Yes
