Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13837 )
Change subject: Fix KuduScanTokenBuilder::SetDiffScan docs ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/13837/2/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/13837/2/src/kudu/client/client.h@2436 PS2, Line 2436: /// Set the start and end timestamp for a diff scan. The timestamps should be : /// encoded HT timestamps. : /// : /// Additionally sets any other scan properties required by diff scans. : /// : /// Private API. : /// : /// @param [in] start_timestamp : /// Start timestamp to set in raw encoded form : /// (i.e. as returned by a previous call to a server). : /// @param [in] end_timestamp : /// End timestamp to set in raw encoded form : /// (i.e. as returned by a previous call to a server). : /// @return Operation result status. nit: given this update puts the KuduScanTokenBuilder::SetDiffScan into the priviate API section, the easier way would be just adding the @cond/@endcond since the source of the reference is under the same conditional. I'll put up a patch to address this. -- To view, visit http://gerrit.cloudera.org:8080/13837 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I448c00b78f9d14685e87d154e1bbee0eaa8e8e24 Gerrit-Change-Number: 13837 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 10 Jul 2019 23:48:24 +0000 Gerrit-HasComments: Yes
