Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13632 )
Change subject: KUDU-2823 Place tablet replicas based on dimension ...................................................................... Patch Set 16: (2 comments) http://gerrit.cloudera.org:8080/#/c/13632/15/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/13632/15/src/kudu/client/client.h@879 PS15, Line 879: /// @note By default (or if the cluster is configured without : /// '--master_place_tablet_replicas_based_on_dimension'), the master will try to place : /// newly created tablet replicas on tablet servers with a small number of tablet replicas. : /// If the dimension label is provided, newly created replicas will be evenly distributed : /// in the cluster based on the dimension label. In other words, the master will try t > Thanks, this is useful. I'd rewrite it though: Done http://gerrit.cloudera.org:8080/#/c/13632/12/src/kudu/master/master.proto File src/kudu/master/master.proto: http://gerrit.cloudera.org:8080/#/c/13632/12/src/kudu/master/master.proto@365 PS12, Line 365: // Indicates that the tablet server needs to report the number of tablets > Still not clear on why this is necessary. Why not have tservers > always report this information? I added some docs, I hope this will be clearer. -- To view, visit http://gerrit.cloudera.org:8080/13632 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I48a225e221eb42ef2f5489687e80a151d8dc1a42 Gerrit-Change-Number: 13632 Gerrit-PatchSet: 16 Gerrit-Owner: Yao Xu <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Yao Xu <[email protected]> Gerrit-Comment-Date: Thu, 11 Jul 2019 02:34:17 +0000 Gerrit-HasComments: Yes
