Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13844 )
Change subject: Autogenerate the release index.md file ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/13844/1/docs/support/scripts/make_site.sh File docs/support/scripts/make_site.sh: http://gerrit.cloudera.org:8080/#/c/13844/1/docs/support/scripts/make_site.sh@a164 PS1, Line 164: : : : : : : First I thought that was something related to this particular change, but then I realized that the removal of these lines is just a follow-up to 819a85fbb, right? http://gerrit.cloudera.org:8080/#/c/13844/1/docs/support/scripts/make_site.sh@165 PS1, Line 165: {KUDU_VERSION} Is there a particular reason to use this sort of substitution pattern instead of @@KUDU_VERSION@@ ? It seems the latter is already in use in other parts of the docs-making (e.g. see support/scripts/make_docs.sh for @@CONFIGURATION_REFERENCE@@ and @@TOOLS_REFERENCE@@ patterns) -- To view, visit http://gerrit.cloudera.org:8080/13844 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If93fe00aa0dd855d8f8fafa22c786747d2ae50ed Gerrit-Change-Number: 13844 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 11 Jul 2019 18:57:12 +0000 Gerrit-HasComments: Yes
