Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13842 )
Change subject: KUDU-2622 Validate read and write default value sizes when deserializing ColumnSchemaPB ...................................................................... Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/13842/2/src/kudu/common/wire_protocol.h File src/kudu/common/wire_protocol.h: http://gerrit.cloudera.org:8080/#/c/13842/2/src/kudu/common/wire_protocol.h@116 PS2, Line 116: boost::optional<ColumnSchema> > > Don't think you need the boost::optional wrapping; just pass Ah yeah I see. And it'd be pretty unnatural to support a default constructor (i.e. ColumnSchema would have to be way more mutable than it is right now). -- To view, visit http://gerrit.cloudera.org:8080/13842 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I434f2aac49402af4f29956ab20bba352dc719eeb Gerrit-Change-Number: 13842 Gerrit-PatchSet: 2 Gerrit-Owner: Yao Xu <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yao Xu <[email protected]> Gerrit-Comment-Date: Mon, 15 Jul 2019 21:51:55 +0000 Gerrit-HasComments: Yes
