Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13878 )
Change subject: [examples] Add a complete Nifi quickstart example ...................................................................... Patch Set 3: (8 comments) http://gerrit.cloudera.org:8080/#/c/13878/3/examples/quickstart/nifi/README.adoc File examples/quickstart/nifi/README.adoc: http://gerrit.cloudera.org:8080/#/c/13878/3/examples/quickstart/nifi/README.adoc@5 PS3, Line 5: rt Kudu Quickstart Container? Environment? http://gerrit.cloudera.org:8080/#/c/13878/3/examples/quickstart/nifi/README.adoc@33 PS3, Line 33: docker nit: capitalize http://gerrit.cloudera.org:8080/#/c/13878/3/examples/quickstart/nifi/README.adoc@62 PS3, Line 62: uild() missing semicolon http://gerrit.cloudera.org:8080/#/c/13878/3/examples/quickstart/nifi/README.adoc@61 PS3, Line 61: KuduClient client = : new KuduClientBuilder("kudu-master-1:7051,kudu-master-2:7151,kudu-master-3:7251").build() : : if(client.tableExists("random_user")) { : client.deleteTable("random_user"); : } : : Schema schema = new Schema(Arrays.asList( : new ColumnSchemaBuilder("ssn", Type.STRING).key(true).build(), : new ColumnSchemaBuilder("firstName", Type.STRING).build(), : new ColumnSchemaBuilder("lastName", Type.STRING).build(), : new ColumnSchemaBuilder("email", Type.STRING).build()) : ); : CreateTableOptions tableOptions = : new CreateTableOptions().setNumReplicas(3).addHashPartitions(Arrays.asList("ssn"), 4); : client.createTable("random_user", schema, tableOptions); Maybe wrap this in {}s so we can copy-paste it? per https://stackoverflow.com/a/53923372 http://gerrit.cloudera.org:8080/#/c/13878/3/examples/quickstart/nifi/README.adoc@91 PS3, Line 91: ssn, firstName, lastName, email nit: maybe put quotes around these? http://gerrit.cloudera.org:8080/#/c/13878/3/examples/quickstart/nifi/README.adoc@98 PS3, Line 98: Them Then http://gerrit.cloudera.org:8080/#/c/13878/3/examples/quickstart/nifi/README.adoc@102 PS3, Line 102: Once the template is added to the canvas you can start each processor by : right-clicking each processor and selecting `Start`. You can also explore : the configuration, queue contents, and more by right-clicking on each element. : This is where I got stuck running through these steps. Was there another processor I was supposed to add? The included template only has a PutKudu processor; seems it needs a source. http://gerrit.cloudera.org:8080/#/c/13878/3/examples/quickstart/nifi/README.adoc@137 PS3, Line 137: le: nit: ... from within the Spark quickstart container -- To view, visit http://gerrit.cloudera.org:8080/13878 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I71f3bc5898c15d7bc19cffb3a91b9efac3f6928b Gerrit-Change-Number: 13878 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 18 Jul 2019 04:40:43 +0000 Gerrit-HasComments: Yes
