Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13884 )
Change subject: Making the -mavx2 flag contingent on the architecture rather than the OS alone ...................................................................... Patch Set 1: (1 comment) a few nits on the commit message, otherwise looks good to me http://gerrit.cloudera.org:8080/#/c/13884/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13884/1//COMMIT_MSG@7 PS1, Line 7: Making the -mavx2 flag contingent on the architecture rather than the OS alone Could you change the summary to mention the JIRA issue, like: KUDU-2897 make mavx2 compiler flag architecture dependent ? In the description, could add some more details on what architectures (except for x86_64) and what compilers you tested the patch against? In case if you need some guidelines for Kudu commit messages, please see https://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project#_commit_guidelines which is referenced from https://kudu.apache.org/docs/contributing.html#_submitting_patches Thank you! -- To view, visit http://gerrit.cloudera.org:8080/13884 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica8c7553cec1fc851685c4a10750e90b3e892500 Gerrit-Change-Number: 13884 Gerrit-PatchSet: 1 Gerrit-Owner: Ritwik Yadav <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 19 Jul 2019 20:57:29 +0000 Gerrit-HasComments: Yes
