Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13770 )
Change subject: KUDU-2882: Increase the timeout value for TestSentryClientMetrics.Basic ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/13770/3/src/kudu/master/sentry_authz_provider-test.cc File src/kudu/master/sentry_authz_provider-test.cc: http://gerrit.cloudera.org:8080/#/c/13770/3/src/kudu/master/sentry_authz_provider-test.cc@1396 PS3, Line 1396: FLAGS_sentry_service_send_timeout_seconds = AllowSlowTests() ? 5 : 2; : FLAGS_sentry_service_recv_timeout_seconds = AllowSlowTests() ? 5 : 2; Given the details of the flake described at https://issues.apache.org/jira/browse/KUDU-2882 , I would expect the test will continue the same way if run without KUDU_ALLOW_SLOW_TESTS environment variable. I would update the threshold for the comparison at lines 1415 and 1417 instead to make this test more stable in other environments. http://gerrit.cloudera.org:8080/#/c/13770/3/src/kudu/master/sentry_authz_provider-test.cc@1415 PS3, Line 1415: 2000000 I think changing this threshold to 1900000 should solve the issue even in case of very unstable system clock and other scheduler anomalies of the OS scheduler. http://gerrit.cloudera.org:8080/#/c/13770/3/src/kudu/master/sentry_authz_provider-test.cc@1417 PS3, Line 1417: 2000000 ditto: 1900000 -- To view, visit http://gerrit.cloudera.org:8080/13770 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3f7f1dc0887b31c4e1a56071be2f0223aeb292e9 Gerrit-Change-Number: 13770 Gerrit-PatchSet: 3 Gerrit-Owner: helifu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: helifu <[email protected]> Gerrit-Comment-Date: Tue, 23 Jul 2019 20:44:51 +0000 Gerrit-HasComments: Yes
