Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13864 )

Change subject: KUDU-2625: Support per-row error check in prepare stage
......................................................................


Patch Set 5:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/13864/5/src/kudu/common/row_operations.h
File src/kudu/common/row_operations.h:

http://gerrit.cloudera.org:8080/#/c/13864/5/src/kudu/common/row_operations.h@113
PS5, Line 113:   Status ConsumeUselessColumn(const ColumnSchema& col);
Nit: maybe call it ReadColumnAndDiscard instead?


http://gerrit.cloudera.org:8080/#/c/13864/3/src/kudu/common/row_operations.cc
File src/kudu/common/row_operations.cc:

http://gerrit.cloudera.org:8080/#/c/13864/3/src/kudu/common/row_operations.cc@616
PS3, Line 616:     ops->push_back(op);
             :   }
             :
> I've removed these code, since per-row errors not supported when return fro
But the per-row errors still propagate through Apply and end up returned to the 
client, right?


http://gerrit.cloudera.org:8080/#/c/13864/5/src/kudu/tablet/tablet.cc
File src/kudu/tablet/tablet.cc:

http://gerrit.cloudera.org:8080/#/c/13864/5/src/kudu/tablet/tablet.cc@461
PS5, Line 461:     if (op->has_result()) continue;
Just so I understand, this is an optimization in that we're not going to apply 
that op (because it failed), so there's no reason to take a lock on its primary 
key?



--
To view, visit http://gerrit.cloudera.org:8080/13864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I497fc3d5d1c9cbb0c183997c9adb8f5efeb9c9d0
Gerrit-Change-Number: 13864
Gerrit-PatchSet: 5
Gerrit-Owner: Yingchun Lai <405403...@qq.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Yingchun Lai <405403...@qq.com>
Gerrit-Comment-Date: Thu, 25 Jul 2019 18:43:52 +0000
Gerrit-HasComments: Yes

Reply via email to