Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13915 )
Change subject: [thirdparty] introduce chrony ...................................................................... Patch Set 1: (4 comments) How long does chrony take to build? http://gerrit.cloudera.org:8080/#/c/13915/1/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: http://gerrit.cloudera.org:8080/#/c/13915/1/thirdparty/build-definitions.sh@1013 PS1, Line 1013: # DESTDIR=$PREFIX \ Remove? http://gerrit.cloudera.org:8080/#/c/13915/1/thirdparty/build-definitions.sh@1019 PS1, Line 1019: ./configure \ Maybe add a comment rationalizing these config options? http://gerrit.cloudera.org:8080/#/c/13915/1/thirdparty/build-thirdparty.sh File thirdparty/build-thirdparty.sh: http://gerrit.cloudera.org:8080/#/c/13915/1/thirdparty/build-thirdparty.sh@577 PS1, Line 577: if [ -n "$F_TSAN" -o -n "$F_CHRONY" ]; then : build_chrony : fi If we're only using it to test, could we put it in F_COMMON instead of F_UNINSTRUMENTED? http://gerrit.cloudera.org:8080/#/c/13915/1/thirdparty/patches/chrony-no-superuser.patch File thirdparty/patches/chrony-no-superuser.patch: PS1: Could you structure the patch as a git commit against master (or 3.5 or whatever)? That way there's more useful metadata that can be used to track provenance after your patch is accepted upstream. -- To view, visit http://gerrit.cloudera.org:8080/13915 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I71ed12311b10979af8a12094881b6b8b47ef8008 Gerrit-Change-Number: 13915 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 25 Jul 2019 19:16:10 +0000 Gerrit-HasComments: Yes
