Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13917 )
Change subject: comment: delete the outdated comment ...................................................................... Patch Set 1: > > Patch Set 1: Code-Review+2 > > > > I couldn't find a document with this name anywhere in Kudu's > commit history. Perhaps it's something David forgot to merge and > has since been lost to time. > > > > Andrew, does this ring any bells to you? > > It doesn't. My best guess is this may have pointed to > https://github.com/apache/kudu/blob/37a81b82cc2e5e1ca9ad7291740b4e963e609bcc/docs/transaction_semantics.adoc#recommendations, > which outlines transaction semantics with respect to scans. > > Patch Set 1: Code-Review+2 > > > > I couldn't find a document with this name anywhere in Kudu's > commit history. Perhaps it's something David forgot to merge and > has since been lost to time. > > > > Andrew, does this ring any bells to you? > > It doesn't. My best guess is this may have pointed to > https://github.com/apache/kudu/blob/37a81b82cc2e5e1ca9ad7291740b4e963e609bcc/docs/transaction_semantics.adoc#recommendations, > which outlines transaction semantics with respect to scans. It seems the reference to docs/design-docs/repeatable-reads.md appeared in time_manager.h in the very first revision. Also, referencing transaction_semantics.adoc from mvcc.h mentions 'clean' time, which is not mentioned anywhere in the top-level of design docs (as I can see). Most likely, it might be a document that David had in his local git workspace, but it hasn't been committed? -- To view, visit http://gerrit.cloudera.org:8080/13917 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6f1a73c19ccb250f02f3faf9993521de3a842b5 Gerrit-Change-Number: 13917 Gerrit-PatchSet: 1 Gerrit-Owner: XiaokaiWang <xiaokai.w...@live.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: XiaokaiWang <xiaokai.w...@live.com> Gerrit-Comment-Date: Thu, 25 Jul 2019 21:23:11 +0000 Gerrit-HasComments: No