Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13936 )
Change subject: [common] add FindColumn for Schecma ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/13936/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13936/2//COMMIT_MSG@7 PS2, Line 7: Schecma Schema http://gerrit.cloudera.org:8080/#/c/13936/2//COMMIT_MSG@10 PS2, Line 10: now add it as a member of Schecma. Schema http://gerrit.cloudera.org:8080/#/c/13936/2/src/kudu/common/schema.h File src/kudu/common/schema.h: http://gerrit.cloudera.org:8080/#/c/13936/2/src/kudu/common/schema.h@509 PS2, Line 509: Status FindColumn(const Slice& col_name, int* idx) const; Doc. Also, you can pass col_name by value; Slices are small enough that it's probably more efficient to copy than to indirect. -- To view, visit http://gerrit.cloudera.org:8080/13936 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iede12b95b774754f914295cecd2f6797008fed46 Gerrit-Change-Number: 13936 Gerrit-PatchSet: 2 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sun, 28 Jul 2019 22:01:30 +0000 Gerrit-HasComments: Yes
