honeyhexin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14016 )
Change subject: [code style] Keep same code style in test files ...................................................................... Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/14016/2/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/14016/2/src/kudu/client/client-test.cc@a4313 PS2, Line 4313: : : : > Why remove the comment? As we have discussed offline, delete these useless comments and out-of-date logic. http://gerrit.cloudera.org:8080/#/c/14016/2/src/kudu/client/client-test.cc@4304 PS2, Line 4304: > Reindent. Done http://gerrit.cloudera.org:8080/#/c/14016/2/src/kudu/consensus/consensus_queue-test.cc File src/kudu/consensus/consensus_queue-test.cc: http://gerrit.cloudera.org:8080/#/c/14016/2/src/kudu/consensus/consensus_queue-test.cc@593 PS2, Line 593: NO_FATALS(UpdatePeerWatermarkToOp(&request, > Reindent the continuation lines here. Done http://gerrit.cloudera.org:8080/#/c/14016/2/src/kudu/consensus/raft_consensus_quorum-test.cc File src/kudu/consensus/raft_consensus_quorum-test.cc: http://gerrit.cloudera.org:8080/#/c/14016/2/src/kudu/consensus/raft_consensus_quorum-test.cc@1048 PS2, Line 1048: NO_FATALS(AssertDurableTermAndVote(kPeerIndex, last_op_id.term() + 1, > Reindent all of the continuation lines affected by your change in this file Done http://gerrit.cloudera.org:8080/#/c/14016/2/src/kudu/util/env-test.cc File src/kudu/util/env-test.cc: http://gerrit.cloudera.org:8080/#/c/14016/2/src/kudu/util/env-test.cc@216 PS2, Line 216: NO_FATALS(ReadAndVerifyTestData(raf.get(), num_slices * slice_size * i, > Reindent. Done http://gerrit.cloudera.org:8080/#/c/14016/2/src/kudu/util/env-test.cc@229 PS2, Line 229: NO_FATALS(ReadAndVerifyTestData(raf.get(), num_slices * slice_size * i, > Reindent. Done -- To view, visit http://gerrit.cloudera.org:8080/14016 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I67689fe8113d88f60ac33fa38504813128209da3 Gerrit-Change-Number: 14016 Gerrit-PatchSet: 3 Gerrit-Owner: honeyhexin <honeyhe...@sohu.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: honeyhexin <honeyhe...@sohu.com> Gerrit-Comment-Date: Tue, 06 Aug 2019 23:28:30 +0000 Gerrit-HasComments: Yes
