Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14020 )
Change subject: POC: Disable Sentry related tests ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/14020/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14020/1//COMMIT_MSG@7 PS1, Line 7: POC: Disable Sentry related tests > May also want to disable the mini cluster options that allow Sentry to be c I was on the fence about this. I wanted to keep this patch as small as possible while still allowing all tests to pass. If some test comes along that tries to use Sentry and it's broken, I think that is okay and we should be aware of the breakage. http://gerrit.cloudera.org:8080/#/c/14020/1/src/kudu/hms/mini_hms.cc File src/kudu/hms/mini_hms.cc: http://gerrit.cloudera.org:8080/#/c/14020/1/src/kudu/hms/mini_hms.cc@127 PS1, Line 127: reoved > removed Done http://gerrit.cloudera.org:8080/#/c/14020/1/src/kudu/integration-tests/CMakeLists.txt File src/kudu/integration-tests/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/14020/1/src/kudu/integration-tests/CMakeLists.txt@93 PS1, Line 93: # NOTE: Sentry tests are disabled to allow upgrading to Hive 3. : #ADD_KUDU_TEST(master_sentry-itest RUN_SERIAL true NUM_SHARDS 8 PROCESSORS 4) > This means we won't even compile the binary though. Could we disable these What's the value in compiling the binary if we never intend for it to be used/run? -- To view, visit http://gerrit.cloudera.org:8080/14020 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7b99b0de221f6d4acfb427f830cd3344c8d0a10b Gerrit-Change-Number: 14020 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 07 Aug 2019 18:52:50 +0000 Gerrit-HasComments: Yes
