Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14018 )
Change subject: Prepare for upgrading to Hive 3 ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/14018/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14018/2//COMMIT_MSG@10 PS2, Line 10: thechanges > nit: space. Done http://gerrit.cloudera.org:8080/#/c/14018/2/src/kudu/hms/mini_hms.h File src/kudu/hms/mini_hms.h: http://gerrit.cloudera.org:8080/#/c/14018/2/src/kudu/hms/mini_hms.h@134 PS2, Line 134: bool schema_initialized_ = false; > nit: add a comment for this? Done http://gerrit.cloudera.org:8080/#/c/14018/2/src/kudu/hms/mini_hms.cc File src/kudu/hms/mini_hms.cc: http://gerrit.cloudera.org:8080/#/c/14018/2/src/kudu/hms/mini_hms.cc@158 PS2, Line 158: // Remove after HADOOP-15966 is available (Hadoop 3.1.3+) > Should this be TODO? Done http://gerrit.cloudera.org:8080/#/c/14018/2/src/kudu/hms/mini_hms.cc@252 PS2, Line 252: Disables the authorization on the DbNotificationListener related metastore APIs. > The comment on HiveConf.java seems to be more clear, so something like 'Dis Done -- To view, visit http://gerrit.cloudera.org:8080/14018 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If43ae2330b3d99374c68bae313a3f8bc070f9c69 Gerrit-Change-Number: 14018 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 08 Aug 2019 20:16:20 +0000 Gerrit-HasComments: Yes
