helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 )
Change subject: KUDU-2797 p2: the master aggregates tablet statistics ...................................................................... Patch Set 31: (3 comments) http://gerrit.cloudera.org:8080/#/c/13426/31/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/13426/31/src/kudu/master/catalog_manager.cc@275 PS31, Line 275: table_stats > I'd like to decouple stats from metrics. Could we just call this "table"? Done http://gerrit.cloudera.org:8080/#/c/13426/31/www/table.mustache File www/table.mustache: http://gerrit.cloudera.org:8080/#/c/13426/31/www/table.mustache@35 PS31, Line 35: Aggregated Live Row Count > nit: maybe remove "Aggregated". I think the user expectation is already tha Done http://gerrit.cloudera.org:8080/#/c/13426/31/www/table.mustache@36 PS31, Line 36: On-disk Size > nit: Can you change this to "On-Disk Size (pre-replication)" or "On-Disk Si Done -- To view, visit http://gerrit.cloudera.org:8080/13426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I74406ab7cca7c22fda455c328b8ee9989a6b2d99 Gerrit-Change-Number: 13426 Gerrit-PatchSet: 31 Gerrit-Owner: helifu <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: helifu <[email protected]> Gerrit-Comment-Date: Sun, 11 Aug 2019 12:49:55 +0000 Gerrit-HasComments: Yes
