Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13975 )
Change subject: KUDU-2901: Consider the available space when selecting data dirs for tablets and blocks. ...................................................................... Patch Set 11: (4 comments) Looks good, just a few doc nits. http://gerrit.cloudera.org:8080/#/c/13975/11//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13975/11//COMMIT_MSG@10 PS11, Line 10: prefrence preference http://gerrit.cloudera.org:8080/#/c/13975/11/src/kudu/fs/data_dirs.cc File src/kudu/fs/data_dirs.cc: http://gerrit.cloudera.org:8080/#/c/13975/11/src/kudu/fs/data_dirs.cc@a89 PS11, Line 89: > Since I have changed the behaviors under this flag, so it is not suitable t FWIW, I think we're comfortable renaming or deleting any flag tagged as 'evolving'. We only maintain compatibility for 'stable' flags. http://gerrit.cloudera.org:8080/#/c/13975/11/src/kudu/util/env_util.h File src/kudu/util/env_util.h: http://gerrit.cloudera.org:8080/#/c/13975/11/src/kudu/util/env_util.h@56 PS11, Line 56: // If 'available_bytes' is not null, it will contain the amount of free disk space (in bytes) Should doc that this behavior (writing to available_bytes) occurs even if the function returns IOError with ENOSPC, but not on any other error. http://gerrit.cloudera.org:8080/#/c/13975/11/src/kudu/util/env_util.h@57 PS11, Line 57: " Drop this double quote. -- To view, visit http://gerrit.cloudera.org:8080/13975 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I194c4965ee64aed728e3b84e684c04d445cbe529 Gerrit-Change-Number: 13975 Gerrit-PatchSet: 11 Gerrit-Owner: ZhangYao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: ZhangYao <[email protected]> Gerrit-Comment-Date: Tue, 13 Aug 2019 18:50:27 +0000 Gerrit-HasComments: Yes
