Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14046 )

Change subject: KUDU-2917 Split a tablet into primary key ranges by number of 
rows
......................................................................


Patch Set 6:

> > It looks like CountLiveRows will return a negative number in some
>  > cases. I will continue to address this issue.
>
> Looks like a bug with CountLiveRows. I tried the fix and ran it locally 1000 
> times without a problem.

Could you pull the fix out into a separate patch (with a unit test), and cc He 
Lifu for review?


--
To view, visit http://gerrit.cloudera.org:8080/14046
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib859c615743ebf7c3b481dfe1bd428769b02f0d7
Gerrit-Change-Number: 14046
Gerrit-PatchSet: 6
Gerrit-Owner: Yao Xu <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yao Xu <[email protected]>
Gerrit-Comment-Date: Tue, 13 Aug 2019 19:02:00 +0000
Gerrit-HasComments: No

Reply via email to