Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/13928 )
Change subject: KUDU-1938 Add non-copy setters to partial row pt 3 ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/13928/5/src/kudu/common/partial_row.h File src/kudu/common/partial_row.h: http://gerrit.cloudera.org:8080/#/c/13928/5/src/kudu/common/partial_row.h@292 PS5, Line 292: ///@{ > This needs to be terminated somewhere, no? Actually it seems to work (just tested), but I left the @{ in L315 by mistake, removing it now. http://gerrit.cloudera.org:8080/#/c/13928/5/src/kudu/common/partial_row.h@352 PS5, Line 352: /// basic validation that the data is not larger than max_column_length*4 as > Also needs to be updated. Done. Problem is that Doxygen seems to group the methods by @name and only one of the docs are used if @names match for all methods with the @name, so I had to put the setters part in the @name. Hope the way I did is okay, let me know if I should change it. -- To view, visit http://gerrit.cloudera.org:8080/13928 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1f2aba098d649eb94e0314f6606cc33600e8d766 Gerrit-Change-Number: 13928 Gerrit-PatchSet: 5 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 13 Aug 2019 21:35:02 +0000 Gerrit-HasComments: Yes
