helifu has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14061 )

Change subject: [tablet] Fixed the bug of DeltaTracker::CountDeletedRows
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

There is a gap between updating "rowset_metadata_" and resetting the 
"deleted_row_count_" indeed. Yeah, it is a bug! Thanks to Yao Xu.

http://gerrit.cloudera.org:8080/#/c/14061/2/src/kudu/tablet/delta_tracker.cc
File src/kudu/tablet/delta_tracker.cc:

http://gerrit.cloudera.org:8080/#/c/14061/2/src/kudu/tablet/delta_tracker.cc@786
PS2, Line 786: 
rowset_metadata_->IncrementLiveRows(-old_dms->deleted_row_count());
It seems to be the only way although it looks a bit obtrusive.



--
To view, visit http://gerrit.cloudera.org:8080/14061
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9bb4456123087778c9dc799777c5990938a84fdf
Gerrit-Change-Number: 14061
Gerrit-PatchSet: 2
Gerrit-Owner: Yao Xu <ocla...@gmail.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: helifu <hzhel...@corp.netease.com>
Gerrit-Comment-Date: Wed, 14 Aug 2019 07:59:36 +0000
Gerrit-HasComments: Yes

Reply via email to