Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/13927 )
Change subject: [docs] fix spark integration examples ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/13927/1/docs/developing.adoc File docs/developing.adoc: http://gerrit.cloudera.org:8080/#/c/13927/1/docs/developing.adoc@112 PS1, Line 112: Below is a minimal Spark SQL "select" example. We first import the kudu spark package, > You don't need to do this, but this could be a good opportunity to link to Done http://gerrit.cloudera.org:8080/#/c/13927/1/docs/developing.adoc@116 PS1, Line 116: NOTE: You can find link:https://github.com/apache/kudu/tree/master/examples/quickstart/spark[quickstart] > Unfortunately this table will haven a random name instead of `default.my_ta The second sample shows how Spark code creates a table, for the first minimal simple, it's not needed to do that in my opinion. http://gerrit.cloudera.org:8080/#/c/13927/1/docs/developing.adoc@124 PS1, Line 124: import org.apache.kudu.spark.kudu._ > Why reduce this to a single master? Given multi-maser is a more common prod I just want to keep the same style with the following two samples. -- To view, visit http://gerrit.cloudera.org:8080/13927 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2a48cc34aea3cc42afd48f43e142a669081f14e2 Gerrit-Change-Number: 13927 Gerrit-PatchSet: 2 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 16 Aug 2019 07:10:04 +0000 Gerrit-HasComments: Yes
