Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14085 )
Change subject: Minor update to kudu-tool-test for macOS. ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14085/1/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/14085/1/src/kudu/tools/kudu-tool-test.cc@4922 PS1, Line 4922: // Linux : Substitute("Network error: Could not connect to the cluster: unable to resolve " : "address for bad: Name or service not known"), : // macOS : Substitute("Network error: Could not connect to the cluster: unable to resolve " : "address for bad: nodename nor servname provided, or not known"))); Rather than bake the possibility of up to two errors into the code, use the preprocessor: // Invalid 'master_addresses' value. NO_FATALS(CheckCorruptClusterInfoConfigFile( Substitute(R"*(clusters_info:)*""\n" R"*( $0:)*""\n" R"*( master_addresses: bad,masters,addresses)*", kClusterName), #ifdef __APPLE__ Substitute("Network error: Could not connect to the cluster: unable to resolve " "address for bad: nodename nor servname provided, or not known"))); #else Substitute("Network error: Could not connect to the cluster: unable to resolve " "address for bad: Name or service not known"))); #endif -- To view, visit http://gerrit.cloudera.org:8080/14085 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ccf7103ae59fe93087be8654cd663a043d2be0e Gerrit-Change-Number: 14085 Gerrit-PatchSet: 1 Gerrit-Owner: Hannah Nguyen <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 16 Aug 2019 23:37:25 +0000 Gerrit-HasComments: Yes
