Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/13976 )
Change subject: [tools] Add table tools to delete column and alter column ...................................................................... Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/13976/11/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/13976/11/src/kudu/tools/kudu-tool-test.cc@3449 PS11, Line 3449: NO_FATALS(check_bad_input(kFloatColumn, "[123]", "unable to parse")); > This case is a surprising to me. Is this because the JsonReader thinks it's Yes, the type of value is not double and ExtractDouble returns Status::InvalidArgument(). Since an int value could be losslessly converted to a double value, maybe int/uint should also be parsed in ExtracDouble of JsonReader? I think parsing both int and double for Double/Float column is a bit rebundant. -- To view, visit http://gerrit.cloudera.org:8080/13976 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I228340e46fe48ffc782c4c7346f890444b8c550f Gerrit-Change-Number: 13976 Gerrit-PatchSet: 11 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Mon, 19 Aug 2019 09:50:36 +0000 Gerrit-HasComments: Yes
