Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/11825 )
Change subject: [test] handle ScanTableToStrings() result status ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/11825/3/src/kudu/client/client-test-util.h File src/kudu/client/client-test-util.h: http://gerrit.cloudera.org:8080/#/c/11825/3/src/kudu/client/client-test-util.h@48 PS3, Line 48: AsIs, I think enumerators should be named either kEnumName or ENUM_NAME. https://google.github.io/styleguide/cppguide.html#Enumerator_Names http://gerrit.cloudera.org:8080/#/c/11825/3/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/11825/3/src/kudu/client/client-test.cc@6074 PS3, Line 6074: TEST_F(ClientTest, TestBlockScannerHijackingAttempts) { These code are not related with commit message, and seem have been merged to master by some other patches, forgot to rebase master branch? -- To view, visit http://gerrit.cloudera.org:8080/11825 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I97a68f4c3ba5041848adddbefeb22e64b42a2745 Gerrit-Change-Number: 11825 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Mon, 19 Aug 2019 12:21:00 +0000 Gerrit-HasComments: Yes
