Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12158 )
Change subject: KUDU-2348: Pick a random replica in RemoteTablet.java ...................................................................... Patch Set 10: (5 comments) Whoops, sorry for not looking at this patch for so long. I was under impression somebody else is taking care of it. Overall looks good to me, just a few nits in the commit message and spacing in the code. Thank you for your contribution! http://gerrit.cloudera.org:8080/#/c/12158/10//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12158/10//COMMIT_MSG@15 PS10, Line 15: fix nit: fixes http://gerrit.cloudera.org:8080/#/c/12158/10//COMMIT_MSG@16 PS10, Line 16: intializer nit: initializer http://gerrit.cloudera.org:8080/#/c/12158/10/java/kudu-client/src/main/java/org/apache/kudu/client/RemoteTablet.java File java/kudu-client/src/main/java/org/apache/kudu/client/RemoteTablet.java: http://gerrit.cloudera.org:8080/#/c/12158/10/java/kudu-client/src/main/java/org/apache/kudu/client/RemoteTablet.java@201 PS10, Line 201: % nit: missing spaces around '%' http://gerrit.cloudera.org:8080/#/c/12158/10/java/kudu-client/src/main/java/org/apache/kudu/client/RemoteTablet.java@216 PS10, Line 216: % nit: missing spaces around '%' http://gerrit.cloudera.org:8080/#/c/12158/10/java/kudu-client/src/main/java/org/apache/kudu/client/RemoteTablet.java@220 PS10, Line 220: % nit: missing spaces around '%' -- To view, visit http://gerrit.cloudera.org:8080/12158 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d70e45d4c9532bb32223c1dddd0936b4ff8fd99 Gerrit-Change-Number: 12158 Gerrit-PatchSet: 10 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Fri, 23 Aug 2019 20:32:35 +0000 Gerrit-HasComments: Yes
