Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14142 )
Change subject: [test] move filter tests from ksck-test to ksck_remote-test ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/14142/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14142/3//COMMIT_MSG@12 PS3, Line 12: This patch moved filter tests to ksck_remote-test Besides the two new functions, are there any other functional changes? Or just code motion? http://gerrit.cloudera.org:8080/#/c/14142/3/src/kudu/tools/ksck_remote-test.cc File src/kudu/tools/ksck_remote-test.cc: http://gerrit.cloudera.org:8080/#/c/14142/3/src/kudu/tools/ksck_remote-test.cc@233 PS3, Line 233: void CreateTableWithNoTablet(const string& table_name) { Calls to this function should wrap it with NO_FATALS() in case one of the ASSERTs fires. http://gerrit.cloudera.org:8080/#/c/14142/3/src/kudu/tools/ksck_remote-test.cc@239 PS3, Line 239: CHECK_OK(b.Build(&schema)); ASSERT_OK here. http://gerrit.cloudera.org:8080/#/c/14142/3/src/kudu/tools/ksck_remote-test.cc@264 PS3, Line 264: vector<string> * vector<string>* -- To view, visit http://gerrit.cloudera.org:8080/14142 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1139bf9b3582ac9fa45bf341ec5b97f8048c92b0 Gerrit-Change-Number: 14142 Gerrit-PatchSet: 3 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 26 Aug 2019 22:17:27 +0000 Gerrit-HasComments: Yes
