Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14179 )
Change subject: [hms] Sync external HMS tables with purge property ...................................................................... Patch Set 1: (6 comments) Just passing through; Andrew/Hao should definitely take a look. http://gerrit.cloudera.org:8080/#/c/14179/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14179/1//COMMIT_MSG@12 PS1, Line 12: Further, in : Hive 4, non-transactional Hive tables will get auto-migrated : to external tables with `external.table.purge=true`. So with this patch, HMS sync is compliant with Hive 3 but not with Hive 4? Because HMS sync still uses the managed table type for sync'ed Kudu tables? http://gerrit.cloudera.org:8080/#/c/14179/1//COMMIT_MSG@17 PS1, Line 17: syncronized synchronized Below too http://gerrit.cloudera.org:8080/#/c/14179/1//COMMIT_MSG@26 PS1, Line 26: manged managed http://gerrit.cloudera.org:8080/#/c/14179/1/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java File java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java: http://gerrit.cloudera.org:8080/#/c/14179/1/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java@187 PS1, Line 187: oldTable.getTableType() Should use oldTableType here. http://gerrit.cloudera.org:8080/#/c/14179/1/src/kudu/hms/hms_client.h File src/kudu/hms/hms_client.h: http://gerrit.cloudera.org:8080/#/c/14179/1/src/kudu/hms/hms_client.h@191 PS1, Line 191: // Returns true if the HMS table is a managed table or an external table with : // `external.table.purge = true`. This should be reworded slightly to avoid ambiguity. As written it's not clear if the necessary condition is: (MANAGED || EXTERNAL) && PURGE Or: MANAGED || (EXTERNAL && PURGE) http://gerrit.cloudera.org:8080/#/c/14179/1/src/kudu/hms/hms_client.cc File src/kudu/hms/hms_client.cc: http://gerrit.cloudera.org:8080/#/c/14179/1/src/kudu/hms/hms_client.cc@413 PS1, Line 413: (table.tableType == hms::HmsClient::kExternalTable && boost::iequals(externalPurge, "true")); Nit: indent by another two chars so the first part of the condition is nicely aligned with the condition on the previous line. -- To view, visit http://gerrit.cloudera.org:8080/14179 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I942515c015b1a4a63cf08383c331c4e19350c312 Gerrit-Change-Number: 14179 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 05 Sep 2019 18:47:05 +0000 Gerrit-HasComments: Yes
