Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/14217 )
Change subject: KUDU-2069 p1: add persistent tserver maintenance mode ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/14217/4/src/kudu/master/ts_state-test.cc File src/kudu/master/ts_state-test.cc: http://gerrit.cloudera.org:8080/#/c/14217/4/src/kudu/master/ts_state-test.cc@189 PS4, Line 189: ASSERT_EQ(kNone, ts_manager_->GetTServerState(kTServer)); Worth checking ASSERT_EQ(1, ts_manager_->GetCount()); after sending heartbeat? -- To view, visit http://gerrit.cloudera.org:8080/14217 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib669b43b3cee171c4c7dbd54041e29c30cb9f767 Gerrit-Change-Number: 14217 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Greg Solovyev <gsolov...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 12 Sep 2019 20:05:30 +0000 Gerrit-HasComments: Yes
