Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14223 )

Change subject: KUDU-2069 p5: recheck tablet health when exiting maintenance 
mode
......................................................................


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/14223/2/src/kudu/integration-tests/maintenance_mode-itest.cc
File src/kudu/integration-tests/maintenance_mode-itest.cc:

http://gerrit.cloudera.org:8080/#/c/14223/2/src/kudu/integration-tests/maintenance_mode-itest.cc@237
PS2, Line 237: brining
nir: bringing


http://gerrit.cloudera.org:8080/#/c/14223/2/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:

http://gerrit.cloudera.org:8080/#/c/14223/2/src/kudu/master/catalog_manager.cc@5003
PS2, Line 5003: ts_manager->SetAllTServersRequireFullTabletReport();
Could it be that the tserver already exited maintenance mode?


http://gerrit.cloudera.org:8080/#/c/14223/2/src/kudu/master/master_service.cc
File src/kudu/master/master_service.cc:

http://gerrit.cloudera.org:8080/#/c/14223/2/src/kudu/master/master_service.cc@375
PS2, Line 375: If
nit: 'Check if'...



--
To view, visit http://gerrit.cloudera.org:8080/14223
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0ab3d78cbc5b1228c01592a00118f11f76e43dd
Gerrit-Change-Number: 14223
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Hao Hao <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 12 Sep 2019 21:06:32 +0000
Gerrit-HasComments: Yes

Reply via email to