Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14212 )
Change subject: KUDU-2920 Block cache capacity validator couldn't run on an NVM block cache ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/14212/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14212/3//COMMIT_MSG@7 PS3, Line 7: couldn't > Looks like you lost one letter too many. :) Done http://gerrit.cloudera.org:8080/#/c/14212/3/src/kudu/cfile/block_cache.h File src/kudu/cfile/block_cache.h: http://gerrit.cloudera.org:8080/#/c/14212/3/src/kudu/cfile/block_cache.h@225 PS3, Line 225: // enough to cause pernicious flushing behavior. See KUDU-2318. : bool ValidateBlockCacheCapacity(); > Nit: rather aggressive line wrapping, no? The Google style guide[1] (which Done http://gerrit.cloudera.org:8080/#/c/14212/3/src/kudu/cfile/cfile-test.cc File src/kudu/cfile/cfile-test.cc: http://gerrit.cloudera.org:8080/#/c/14212/3/src/kudu/cfile/cfile-test.cc@1064 PS3, Line 1064: " > nit: seems to be an extra single quote Done -- To view, visit http://gerrit.cloudera.org:8080/14212 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f50e9dd901280b5c32576e43165292299922995 Gerrit-Change-Number: 14212 Gerrit-PatchSet: 4 Gerrit-Owner: Volodymyr Verovkin <verjov...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin <verjov...@cloudera.com> Gerrit-Comment-Date: Fri, 13 Sep 2019 21:52:53 +0000 Gerrit-HasComments: Yes
