Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14222 )
Change subject: KUDU-2069 p4: stop replication from failed servers in maintenance mode ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/14222/2/src/kudu/master/ts_manager.h File src/kudu/master/ts_manager.h: http://gerrit.cloudera.org:8080/#/c/14222/2/src/kudu/master/ts_manager.h@94 PS2, Line 94: void GetWhitelistedUuids(std::unordered_set<std::string>* uuids) const; Not sure I understand why that would be any better than generating the list up front. Passing in a const ref to ShouldAddReplica() doesn't seem expensive at all. With this call pulled out of the loop, aren't they equivalent, but with less complexity in this implementation? Or is the concern around the memory used by the whitelist? Also what name would you prefer? I think "whitelisting" is apt, but you are the second person to mention this and I haven't been able to think of a better name. > a list of people or things considered to be acceptable or trustworthy. > "the software applies a blacklist of spammers and a whitelist of known good > senders" -- To view, visit http://gerrit.cloudera.org:8080/14222 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a63b55011d16900c0d27eac0eb75880074204db Gerrit-Change-Number: 14222 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sun, 15 Sep 2019 06:44:10 +0000 Gerrit-HasComments: Yes
