Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/14245 )
Change subject: KUDU-2949: fix tablet stats race while ProcessTabletReport ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/14245/1/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/14245/1/src/kudu/master/catalog_manager.cc@4235 PS1, Line 4235: // Right now the tserver only reports the LEADER replicas its own. I know, this comment was here already, but something is not right with how it is phrased. Does it mean "LEADER replicas that it owns" ? http://gerrit.cloudera.org:8080/#/c/14245/1/src/kudu/master/catalog_manager.cc@4239 PS1, Line 4239: // We use the tablet lock to prevent concurrent update the table metrics. This last line of comment seems to belong inside UpdateStats method http://gerrit.cloudera.org:8080/#/c/14245/1/src/kudu/master/catalog_manager.cc@5370 PS1, Line 5370: void TabletInfo::UpdateStats(ReportedTabletStatsPB stats) { Perhaps, this method should be renamed now that it updates both stats and metrics? -- To view, visit http://gerrit.cloudera.org:8080/14245 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic89070bcdb201e2a620efd8fc50041cebd8a7e26 Gerrit-Change-Number: 14245 Gerrit-PatchSet: 1 Gerrit-Owner: helifu <hzhel...@corp.netease.com> Gerrit-Reviewer: Greg Solovyev <gsolov...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 17 Sep 2019 21:35:27 +0000 Gerrit-HasComments: Yes
