Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14250 )
Change subject: messenger: adjust lock usage ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/14250/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14250/1//COMMIT_MSG@11 PS1, Line 11: take the lock in the destructor Does it make sense to replace closing_ with atomic and don't guard it with lock_ at all? http://gerrit.cloudera.org:8080/#/c/14250/1//COMMIT_MSG@18 PS1, Line 18: but one way to avoid it Does it mean it's not possible to fix the Messenger lifecycle issue (if any)? I'm curious how it happens that Messenger object is being destructed while some other thread calls ShutdownInternal(). -- To view, visit http://gerrit.cloudera.org:8080/14250 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1fd93c06b14bc97a9ac4a37a5b6ca55ffa38f544 Gerrit-Change-Number: 14250 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 18 Sep 2019 00:38:03 +0000 Gerrit-HasComments: Yes
