Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14258 )
Change subject: hms: stop trying to get the UUID on success ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/14258/2/src/kudu/hms/hms_catalog.cc File src/kudu/hms/hms_catalog.cc: http://gerrit.cloudera.org:8080/#/c/14258/2/src/kudu/hms/hms_catalog.cc@469 PS2, Line 469: if (s.IsNotSupported()) { > Just to clarify, if the HMS is still starting up, do we wind up here? Or do If it's starting up, we'll loop and try again, since the HmsClient::GetUuid() response won't be NotSupported; it'll be something like RemoteError. HmsCatalog::GetUuid() will only ever return OK or NotSupported though. That's documented in the header. -- To view, visit http://gerrit.cloudera.org:8080/14258 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I71156c0756bac8fdb73929a740cc0d9093bc29c2 Gerrit-Change-Number: 14258 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 18 Sep 2019 21:51:14 +0000 Gerrit-HasComments: Yes
