Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14271 )
Change subject: Removed repeating chunk of code in kudu-admin-test ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/14271/1/src/kudu/tools/kudu-admin-test.cc File src/kudu/tools/kudu-admin-test.cc: http://gerrit.cloudera.org:8080/#/c/14271/1/src/kudu/tools/kudu-admin-test.cc@168 PS1, Line 168: protected: > Nit: visibility labels should be indented by one character. Done http://gerrit.cloudera.org:8080/#/c/14271/1/src/kudu/tools/kudu-admin-test.cc@170 PS1, Line 170: ails* > nit: maybe, make it a constant method? Done http://gerrit.cloudera.org:8080/#/c/14271/1/src/kudu/tools/kudu-admin-test.cc@174 PS1, Line 174: const auto *ts > nit: replace with 'auto*' or 'const auto*' ? Done http://gerrit.cloudera.org:8080/#/c/14271/1/src/kudu/tools/kudu-admin-test.cc@176 PS1, Line 176: return ts; : } > nit: we could return ts directly here and not declare new_node. Done -- To view, visit http://gerrit.cloudera.org:8080/14271 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib7ad71fa2ade7fd4c8aeacc8c0a732519811e21c Gerrit-Change-Number: 14271 Gerrit-PatchSet: 3 Gerrit-Owner: Volodymyr Verovkin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Comment-Date: Fri, 20 Sep 2019 20:11:42 +0000 Gerrit-HasComments: Yes
