Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14260 )
Change subject: [consensus] KUDU-2947 fix voting in case of slow WAL ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/14260/3/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: http://gerrit.cloudera.org:8080/#/c/14260/3/src/kudu/consensus/raft_consensus.cc@1420 PS3, Line 1420: SnoozeFailureDetector(); > I know they're not coupled right now, but I wonder if it would make sense t I thought about that, yes. However, introducing the mentioned approach would require introducing substantial changes into the code. I think we can do that in a separate follow-up changelist. I'd like to keep this changelist less invasive to cherry pick it easily to maintenance branches, if needed. http://gerrit.cloudera.org:8080/#/c/14260/3/src/kudu/integration-tests/raft_consensus_election-itest.cc File src/kudu/integration-tests/raft_consensus_election-itest.cc: http://gerrit.cloudera.org:8080/#/c/14260/3/src/kudu/integration-tests/raft_consensus_election-itest.cc@578 PS3, Line 578: if (!AllowSlowTests()) { : LOG(WARNING) << "test is skipped; set KUDU_ALLOW_SLOW_TESTS=1 to run"; : return; : } > nit: you can use SKIP_IF_SLOW_NOT_ALLOWED() for this Done http://gerrit.cloudera.org:8080/#/c/14260/3/src/kudu/integration-tests/raft_consensus_election-itest.cc@613 PS3, Line 613: but it's assumed a loopback interface : // that should not be the case. The consensus RPC queues are not supposed : // to be overflown. > I don't quite follow this bit here. What's the loopback interface? And why The loopback interface: https://askubuntu.com/questions/247625/what-is-the-loopback-device-and-how-do-i-use-it The point here is that no heartbeat loss should happen in this scenario. I updated the comment; hopefully it's clearer now. http://gerrit.cloudera.org:8080/#/c/14260/3/src/kudu/integration-tests/raft_consensus_election-itest.cc@711 PS3, Line 711: not > Remove Done -- To view, visit http://gerrit.cloudera.org:8080/14260 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7c061b498e727a1a11e94e03c55530eeebfdf8dd Gerrit-Change-Number: 14260 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Comment-Date: Fri, 20 Sep 2019 21:44:46 +0000 Gerrit-HasComments: Yes
