Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14287 )
Change subject: KUDU-2952: fix TOCTOU race in reporting stats ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/14287/2/src/kudu/integration-tests/ts_tablet_manager-itest.cc File src/kudu/integration-tests/ts_tablet_manager-itest.cc: http://gerrit.cloudera.org:8080/#/c/14287/2/src/kudu/integration-tests/ts_tablet_manager-itest.cc@427 PS2, Line 427: ASSERT_EQ(reported_leader_uuid, mts_uuid); : } > nit: if ASSERT_EQ() above ever fails, it's better to put these into a Scope Done -- To view, visit http://gerrit.cloudera.org:8080/14287 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I29fe63cb42c82a08a4811d42b244abeb2fa86bd9 Gerrit-Change-Number: 14287 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: helifu <[email protected]> Gerrit-Comment-Date: Tue, 24 Sep 2019 16:35:15 +0000 Gerrit-HasComments: Yes
