Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/14295 )
Change subject: KUDU-2800 ...................................................................... Patch Set 1: (2 comments) This commit needs a description http://gerrit.cloudera.org:8080/#/c/14295/1/src/kudu/consensus/consensus_queue.cc File src/kudu/consensus/consensus_queue.cc: http://gerrit.cloudera.org:8080/#/c/14295/1/src/kudu/consensus/consensus_queue.cc@604 PS1, Line 604: // LOG(INFO) << " HealthReportPB::HEALTHY " << peer.ToString(); Why leave this commented line here? http://gerrit.cloudera.org:8080/#/c/14295/1/src/kudu/integration-tests/raft_config_change-itest.cc File src/kudu/integration-tests/raft_config_change-itest.cc: http://gerrit.cloudera.org:8080/#/c/14295/1/src/kudu/integration-tests/raft_config_change-itest.cc@496 PS1, Line 496: follower->mutable_flags()->emplace_back("--tablet_open_bootstrap_inject_latency_ms=25000"); does bootstrap need to be 5x follower_unavailable_considered_failed_sec, or can it be just a bit longer than follower_unavailable_considered_failed_sec? -- To view, visit http://gerrit.cloudera.org:8080/14295 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ae309bb10ebe40e89c74d132623c89448d0a8f1 Gerrit-Change-Number: 14295 Gerrit-PatchSet: 1 Gerrit-Owner: Volodymyr Verovkin <verjov...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Greg Solovyev <gsolov...@cloudera.com> Gerrit-Comment-Date: Tue, 24 Sep 2019 21:49:53 +0000 Gerrit-HasComments: Yes
