Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14306 )
Change subject: add a tool to create table ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/14306/1/src/kudu/tools/tool.proto File src/kudu/tools/tool.proto: http://gerrit.cloudera.org:8080/#/c/14306/1/src/kudu/tools/tool.proto@341 PS1, Line 341: // lower bound value in format of string, include the value. : optional string in_lower_bound = 1; : // lower bound value in format of string, exclude the value. : optional string ex_lower_bound = 2; : // upper bound value in format of string, include the value. : optional string in_upper_bound = 3; : // upper bound value in format of string, exclude the value. : optional string ex_upper_bound = 4; > message RangeBoundPB { Almost. Maybe this? message RangeBoundPB { message BoundPB { enum Type { INCLUSIVE = 0; EXCLUSIVE = 1; } optional Type bound_type = 1; optional string bound_value = 2; } optional BoundPB lower_bound = 1; optional BoundPB upper_bound = 2; } http://gerrit.cloudera.org:8080/#/c/14306/1/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/14306/1/src/kudu/tools/tool_action_table.cc@911 PS1, Line 911: } else if (type == "DECIMAL") { > Yes. but we should change the first parameter of function ConvertToKuduPart Yeah, though you might want to combine the first two args (const vector<pair<string, DataType>>& columns ) because both vectors are always guaranteed to be the same length. Then you can figure out how to adapt a KuduTable into that (by parsing its KuduSchema) for the existing call site. -- To view, visit http://gerrit.cloudera.org:8080/14306 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bce4733a504f8ef5f024089a16fe3c6f1e493f1 Gerrit-Change-Number: 14306 Gerrit-PatchSet: 2 Gerrit-Owner: YangSong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: YangSong <[email protected]> Gerrit-Comment-Date: Fri, 27 Sep 2019 05:22:32 +0000 Gerrit-HasComments: Yes
