Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14341 )
Change subject: test: deflake TestBackgroundFailureDuringMaintenanceMode ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/14341/1/src/kudu/integration-tests/maintenance_mode-itest.cc File src/kudu/integration-tests/maintenance_mode-itest.cc: http://gerrit.cloudera.org:8080/#/c/14341/1/src/kudu/integration-tests/maintenance_mode-itest.cc@a438 PS1, Line 438: > I'm curious why this was not failing all the time. Just before evaluating It was because AssertEventuallyNumFailedReplicas(0) only checked for failed tablets, rather than healthy tablets. So if there were a leader election, which I guess was pretty likely over the course of thirty seconds given the low timeout, we'd refresh the health states and see UNKNOWN instead of FAILED. I've updated the method to be more explicit. http://gerrit.cloudera.org:8080/#/c/14341/1/src/kudu/integration-tests/maintenance_mode-itest.cc@453 PS1, Line 453: }); > Do we still need this? Done -- To view, visit http://gerrit.cloudera.org:8080/14341 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I67eed008a983cd9ed528496777ffe3d30126a55f Gerrit-Change-Number: 14341 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 02 Oct 2019 04:39:24 +0000 Gerrit-HasComments: Yes
